Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying text to system clipboard on Linux using xclip #3937

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Feb 1, 2024

PR Summary

Fix #1993
Fix #3884

Fix copying text to system clipboard on Linux using xclip.
Avoid reading the standard output pipe when it's not needed to do so. So, we redirect but don't read the stdout when setting text to clipboard using xclip, and only read the output when we are getting text from the clipboard.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests only able to test manually
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@daxian-dbw daxian-dbw merged commit 826f73e into master Feb 2, 2024
3 checks passed
@daxian-dbw daxian-dbw deleted the copy branch February 2, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants