ACR Integration: Bug fix for publishing a module that is not all lowercase to ACR repo #1502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses a small bug when publishing to ACR registries. ACR only allows all lowercase names. This PR takes all module names and ensures that it's lowercase when publishing to ACR. It does not modify the files or .nupkg, just the name that gets sent in the HTTP calls to ACR.
PR Context
Previously, when attempting to publish 'TestModule.psd1' a 404 error would be returned. The exact same file named 'testmodule.psd1' would successfully publish. This is because the Publish-PSResource implementation gets the module name from the file
_pkgName = System.IO.Path.GetFileNameWithoutExtension(pathToFileToPublish)
. However, ACR does not care about the casing of the file or the .nupkg, just the metadata it receives.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.