Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InstallName() #1506

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Remove InstallName() #1506

merged 2 commits into from
Jan 8, 2024

Conversation

anamnavi
Copy link
Member

@anamnavi anamnavi commented Jan 5, 2024

PR Summary

InstallName() method can be removed from ServerAPICalls classes. We do find first, so the package version is always known and InstallVersion() method is always called. So InstallName() code is dead code and can be removed.

PR Context

PR Checklist

@anamnavi anamnavi merged commit c64719e into PowerShell:master Jan 8, 2024
4 checks passed
alerickson pushed a commit to alerickson/PSResourceGet that referenced this pull request Apr 1, 2024
* remove InstallName dead code

* code cleanup
alerickson pushed a commit to alerickson/PSResourceGet that referenced this pull request Apr 2, 2024
* remove InstallName dead code

* code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants