Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACR publish tests #1561

Closed
wants to merge 65 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
00aacfc
Enable testing against ACR
adityapatwardhan Feb 2, 2024
9929dfd
Fix yaml
adityapatwardhan Feb 2, 2024
b490e24
Add ACR install tests
alerickson Feb 10, 2024
525eb80
Add publish tests
alerickson Feb 10, 2024
179d096
Update test/FindPSResourceTests/FindPSResourceACRServer.Tests.ps1
adityapatwardhan Feb 10, 2024
de2179c
Merge branch 'master' of https://github.com/PowerShell/PSResourceGet …
alerickson Feb 13, 2024
2c81e02
Enable testing against ACR
adityapatwardhan Feb 2, 2024
f0a3f1c
Fix yaml
adityapatwardhan Feb 2, 2024
5e97ee4
Update test/FindPSResourceTests/FindPSResourceACRServer.Tests.ps1
adityapatwardhan Feb 10, 2024
cf7b385
Add ACR install tests
alerickson Feb 10, 2024
a1e36a8
Merge branch 'AddACRTests' of https://github.com/adityapatwardhan/PSR…
alerickson Feb 13, 2024
0aedf82
Merge branch 'addACRTests' of https://github.com/alerickson/PSResourc…
alerickson Feb 13, 2024
aa040c1
Merge branch 'master' of https://github.com/powershell/PSResourceGet …
alerickson Feb 14, 2024
0fad988
Update Install tests
alerickson Feb 14, 2024
323e2cd
Update tests
alerickson Feb 14, 2024
d841b25
Update test
alerickson Feb 14, 2024
7e38312
Update test
alerickson Feb 14, 2024
d4baed4
Merge branch 'master' of https://github.com/powershell/PSResourceGet …
alerickson Feb 14, 2024
2e1a9f4
update test
alerickson Feb 14, 2024
e1ad835
Add / to repo uri
alerickson Feb 14, 2024
b7f8f47
Add debugging
alerickson Feb 14, 2024
5f46a60
Add separate tests for install -Name '*'
alerickson Feb 14, 2024
429a864
update github wildcard tests
alerickson Feb 14, 2024
83c6891
update github tests
alerickson Feb 14, 2024
3e54e61
update tests
alerickson Feb 14, 2024
a45cafc
Remove whitespace
alerickson Feb 14, 2024
b3d4bd5
uninstall all test resources before running tests
alerickson Feb 14, 2024
d1bfd3c
Move uninstall to end of beforeall statement
alerickson Feb 14, 2024
ac694f2
Merge branch 'addACRTests' of https://github.com/alerickson/PSResourc…
alerickson Feb 14, 2024
0e59193
Merge branch 'master' of https://github.com/powershell/PSResourceGet …
alerickson Feb 14, 2024
ce048e6
Finish up modifying tests
alerickson Feb 14, 2024
63ed03c
Add GUID to test module name
alerickson Feb 15, 2024
4157194
Add GUID to 'ModuleWithMissingRequiredModule'
alerickson Feb 15, 2024
559244b
Add debugging messages
alerickson Feb 15, 2024
807ed50
Rerunning tests
alerickson Feb 15, 2024
36cab7f
add more debugging message
alerickson Feb 15, 2024
39c65c6
Comment out test
alerickson Feb 15, 2024
79a10cb
Revert changes made for testing locally
alerickson Feb 15, 2024
23471ca
Uncomment failing test
alerickson Feb 15, 2024
6b6252b
Remove -Verbose -Debug
alerickson Feb 15, 2024
15eda37
Add Should Not Throw
alerickson Feb 15, 2024
d7acba2
Add exception catch to PublishPSResource, and -Force param to New-Ite…
alerickson Feb 15, 2024
3caf02c
ThrowTerminatingError in PublishPSResource, delete ModuleBase dir aft…
alerickson Feb 16, 2024
b32c2c8
Add 'throw e' to catch block
alerickson Feb 16, 2024
e3d5db5
Ensure that exception is not swallowed by finally block
adityapatwardhan Feb 16, 2024
b1a8061
Add logging
alerickson Feb 16, 2024
e969e5e
Add -Verbose -Debug to Save
alerickson Feb 16, 2024
5827c8f
Add -TrustRepository to Save
alerickson Feb 16, 2024
d62d2f4
Add WriteError to ACRServerAPICalls class
alerickson Feb 17, 2024
2547e36
Add more WriteErrors in ACR Server class
alerickson Feb 17, 2024
d0d426c
Write more verbose messaging
alerickson Feb 17, 2024
09d5b39
Add more logging
alerickson Feb 17, 2024
379f4bd
Add more logging
alerickson Feb 17, 2024
a55f07f
Add more debugging in installhelper
alerickson Feb 17, 2024
3acd8b4
Add more logging
alerickson Feb 17, 2024
d336f55
Add more logging
alerickson Feb 17, 2024
fa805ee
Remove -Verbose -Debug from Save
alerickson Feb 17, 2024
d1e5098
Clean up files
alerickson Feb 20, 2024
d8d8c0c
Clean up a bit more
alerickson Feb 20, 2024
de19412
Merge branch 'master' of https://github.com/powershell/PSResourceGet …
alerickson Feb 22, 2024
a4c3ca8
remove whitespace
alerickson Feb 22, 2024
b9a7d09
Remove unnecessary write errors
alerickson Feb 22, 2024
1a37443
Update test/PublishPSResourceTests/PublishPSResourceACRServer.Tests.ps1
alerickson Feb 22, 2024
d38e5d7
Update test/PublishPSResourceTests/PublishPSResourceACRServer.Tests.ps1
alerickson Feb 22, 2024
1a8745d
Update test/PublishPSResourceTests/PublishPSResourceACRServer.Tests.ps1
alerickson Feb 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/code/ACRServerAPICalls.cs
Original file line number Diff line number Diff line change
Expand Up @@ -701,12 +701,10 @@ internal Hashtable GetACRMetadata(string registry, string packageName, NuGetVers
* ]
* }
*/

Tuple<string,string> metadataTuple = GetMetadataProperty(foundTags, packageName, out Exception exception);
if (exception != null)
{
errRecord = new ErrorRecord(exception, "FindNameFailure", ErrorCategory.InvalidResult, this);

return requiredVersionResponse;
}

Expand Down Expand Up @@ -769,7 +767,6 @@ internal Tuple<string,string> GetMetadataProperty(JObject foundTags, string pack
}

var metadata = annotations["metadata"].ToString();

var metadataPkgTitleJToken = annotations["org.opencontainers.image.title"];
if (metadataPkgTitleJToken == null)
{
Expand Down
Loading
Loading