Update build infrastructure #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
update-build-infra
branch
3 times, most recently
from
58b962b
to
9a0e943
Compare
and also unfinished about topic
andyleejordan
force-pushed
the
update-build-infra
branch
7 times, most recently
from
fddf4ce
to
590c2ec
Compare
For one, they are supposed to support Desktop edition.
Previously these would fail if the Pester output configuration was changed. Instead, use `Throw` properly to check `ErrorId` and force errors to throw (instead of relying on `ErrorVariable`).
andyleejordan
force-pushed
the
update-build-infra
branch
2 times, most recently
from
55c76d4
to
b60c2f8
Compare
Note that the DLLs are going to remain loaded regardless.
Pin the SDK, use CFS, and enable cache on CI.
Since 4.6.1 is out of support.
andyleejordan
force-pushed
the
update-build-infra
branch
from
b60c2f8
to
3bc2cf4
Compare
andyleejordan
commented
Aug 3, 2024
There was a problem hiding this comment.
All right, I carefully reviewed the changes I took in from Patrick's PR, and the changes I added. I downloaded the existing packages from the PowerShell Gallery and NuGet (the module and library respectively) and compared their contents. I'm reasonably confident we didn't miss anything. Now on to creating the new pipelien with signing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues (and hopefully finishes) #224.