Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spigot] Add support for 1.18 #149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[spigot] Add support for 1.18 #149

wants to merge 2 commits into from

Conversation

ikfir
Copy link
Member

@ikfir ikfir commented Aug 12, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation)
  • 🐞 Bug fix (fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)

πŸ“š Description

Did ofir job
TODO

  • Need to add mock bukkit 1.18.2 to nexus

Closes #147

πŸ§ͺ How Has This Been Tested?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Did ofir job
Need to add mock bukkit 1.18.2 to nexus
Closes #147
@ikfir ikfir requested a review from liorsl August 12, 2024 14:52
@@ -21,6 +21,7 @@
MinecraftVersion minecraftVersion = ServerUtils.getVersion();
return switch (minecraftVersion.update()) {
case 8 -> constructImpl("ItemFactory_1_8_R1");
case 18 -> constructImpl("ItemFactory_1_18_2_R1");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to glow effect as well

@liorsl liorsl changed the title Add support for 1.18 [spigot] Add support for 1.18 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spigot 1.18.2
1 participant