Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Variables correctifs #1303

Merged
merged 10 commits into from
Apr 3, 2023

Conversation

znicholasbrown
Copy link
Contributor

This PR:

  • fixes an issue where create and edit modals had incorrect save/create/close ordering
  • adds a check for value length (max 255 chars)
  • ensures update is emitted across nested components (so any consumers can subscribe and refresh their data when a change has taken place)
  • adds key to the VariableMenu instantiation in the table to work around an issue in prefect-design (I don't want to tackle that issue as part of this since that could have broader impact)
  • truncates name and value columns

table before:

Screenshot 2023-04-03 at 12 23 12 PM

table after:

Screenshot 2023-04-03 at 12 22 53 PM

@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for prefect-ui-library ready!

Name Link
🔨 Latest commit c714cd2
🔍 Latest deploy log https://app.netlify.com/sites/prefect-ui-library/deploys/642b0b51e73220000815271b
😎 Deploy Preview https://deploy-preview-1303--prefect-ui-library.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@znicholasbrown
Copy link
Contributor Author

Closes: #1300
Closes: #1301

src/components/VariableCreateModal.vue Outdated Show resolved Hide resolved
src/components/VariableEditModal.vue Outdated Show resolved Hide resolved
src/components/VariableEditModal.vue Outdated Show resolved Hide resolved
src/components/VariableCreateModal.vue Outdated Show resolved Hide resolved
@znicholasbrown
Copy link
Contributor Author

Addressed your comments @pleek91 (some were no longer valid once I removed the in-component validation method); I've opened up a ticket for overhauling these validation utilities as they're a bit tough to keep track of atm and I don't want to address them in this PR

@znicholasbrown znicholasbrown merged commit 46c4893 into main Apr 3, 2023
@znicholasbrown znicholasbrown deleted the enhancement-variables-2023-04-03 branch April 3, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants