Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WorkQueue CRUD methods in client #16568

Closed
wants to merge 14 commits into from
Closed

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jan 1, 2025

Related to #16472, this PR continues the optimization pattern established for Artifacts. Like the previous PRs, it:

  • Refactors the client's WorkQueue CRUD methods into a standalone module
  • Uses ForwardRefs for heavy imports, moving them into the call itself

Copy link

codspeed-hq bot commented Jan 1, 2025

CodSpeed Performance Report

Merging #16568 will not alter performance

Comparing work-queue-client (05497e8) with main (1c801c7)

Summary

✅ 3 untouched benchmarks

Comment on lines +568 to +574
<<<<<<< HEAD
names (List[str]): A list of limit names for which to increment limits.
task_run_id (UUID): The task run ID incrementing the limits.
=======
names: A list of limit names for which to increment limits.
task_run_id: The task run ID incrementing the limits.
>>>>>>> main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a conflict that needs to be resolved.

@aaazzam aaazzam closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants