Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start incremental pendulum consolidation #16808

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Jan 22, 2025

moving use of pendulum into prefect.types so we can switch off, taking up the torch from #16609 , which bit off more than I intended

Would also like to gather feedback about the strategy to replicating the top level utils (outside DateTime, Date etc) from pendulum like pendulum.parse

my initial thoughts are that we:

  • pick sane but bespoke names (easy to mass replace later)
  • keep them all in a private module prefect.types._datetime
  • eventually implement the same API, improving it as needed before putting it in prefect.types proper

@zzstoatzz zzstoatzz changed the title very first consolidation start incremental pendulum consolidation Jan 22, 2025
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #16808 will not alter performance

Comparing pendulum-consolidation-1 (93e1d12) with main (310612b)

Summary

✅ 2 untouched benchmarks

@zzstoatzz zzstoatzz force-pushed the pendulum-consolidation-1 branch from a9ae211 to 93e1d12 Compare January 22, 2025 02:08
@zzstoatzz zzstoatzz merged commit 7548f1b into main Jan 22, 2025
47 checks passed
@zzstoatzz zzstoatzz deleted the pendulum-consolidation-1 branch January 22, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants