Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds search params for the deployment details route #16991

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[UI v2] feat: Adds search params for the deployment details route #16991

merged 1 commit into from
Feb 6, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 5, 2025 •
edited
Loading

Adds search params to deployment details route

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 5, 2025
@devinvillarosa devinvillarosa force-pushed the add-search-params-flow-details-page branch from fa2ded4 to f1b4cfb Compare February 5, 2025 20:32
@devinvillarosa devinvillarosa force-pushed the add-search-params-flow-details-page branch from f1b4cfb to 076122a Compare February 6, 2025 18:09
pleek91
pleek91 reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinvillarosa devinvillarosa merged commit d860001 into main Feb 6, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the add-search-params-flow-details-page branch February 6, 2025 20:11
kevingrismore pushed a commit that referenced this pull request Feb 7, 2025
@devinvillarosa @kevingrismore
[UI v2] feat: Adds search params for the deployment details route (#1…
0369a2b 
…6991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleek91 pleek91 pleek91 approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@devangrose devangrose Awaiting requested review from devangrose devangrose is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @pleek91