Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some log noise in pause and abort handling #17014

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 6, 2025

Two things:

  • our exception types have no repr/str of value; f"{Pause()}" prints an empty string, so I removed this from the log
  • we log "unexpected exception" when catching exceptions that are more expected than unexpected; we have special handling for these exception types so shouldn't say they were unexpected

Closes #16915

@github-actions github-actions bot added enhancement An improvement of an existing feature labels Feb 6, 2025
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #17014 will not alter performance

Comparing improve-pause-abort-error-handling (641e46e) with main (750b9ce)

Summary

✅ 2 untouched benchmarks

@cicdw cicdw merged commit e38b549 into main Feb 7, 2025
49 checks passed
@cicdw cicdw deleted the improve-pause-abort-error-handling branch February 7, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling suspend_flow_run raises an exception
2 participants