Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] chore: Removes toggleVariants as an export #17054

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 7, 2025

Exporting this would give an eslint warning (which shows up in all UI related PRs).
Separating the variants into another file for now and exporting it through an index.ts file

If needed, we can move toggleVariant as its own file and import/export it from there

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 7, 2025
@devinvillarosa devinvillarosa marked this pull request as draft February 7, 2025 23:11
@devinvillarosa devinvillarosa force-pushed the remove-toggleVariant-from-export branch from b5ce5b6 to d200452 Compare February 7, 2025 23:13
@devinvillarosa devinvillarosa marked this pull request as ready for review February 7, 2025 23:14
@devinvillarosa devinvillarosa merged commit b4ec412 into main Feb 10, 2025
11 checks passed
@devinvillarosa devinvillarosa deleted the remove-toggleVariant-from-export branch February 10, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants