Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pendulum consolidation in prefect.client #17099

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

zzstoatzz
Copy link
Collaborator

related to #16910

@@ -607,7 +608,7 @@ async def get_runs_in_work_queue(
List[FlowRun]: a list of FlowRun objects read from the queue
"""
if scheduled_before is None:
scheduled_before = pendulum.now("UTC")
scheduled_before = DateTime.now("UTC")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have the most recent changes from main, you should be able to use now from prefect.types._datetime.

Suggested change
scheduled_before = DateTime.now("UTC")
scheduled_before = now("UTC")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #17099 will not alter performance

Comparing pendulum-consolidation-client (a2180c7) with main (955378c)

Summary

✅ 2 untouched benchmarks

@zzstoatzz zzstoatzz requested a review from desertaxle February 11, 2025 19:45
@zzstoatzz zzstoatzz added the development Tech debt, refactors, CI, tests, and other related work. label Feb 11, 2025
@zzstoatzz zzstoatzz merged commit b87f0e8 into main Feb 11, 2025
49 checks passed
@zzstoatzz zzstoatzz deleted the pendulum-consolidation-client branch February 11, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants