Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pendulum consolidation in several modules #17103

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Feb 11, 2025

related to #16910

  • deployments/flow_runs.py
  • docker/docker_image.py
  • events/{clients.py related.py}
  • locking/filesystem.py
  • logging/handlers.py
  • runtime/flow_run.py

@github-actions github-actions bot added the development Tech debt, refactors, CI, tests, and other related work. label Feb 11, 2025
since=pendulum.now("UTC").subtract(minutes=1),
until=pendulum.now("UTC").add(years=1),
since=now("UTC") - timedelta(minutes=1),
until=now("UTC") + timedelta(weeks=52),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is one area where pendulum is helping us. We might need a specific utility for adding a year for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in 5bd520e

Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #17103 will not alter performance

Comparing pendulum-consolidation-mega (c0389d2) with main (bf451fb)

Summary

✅ 2 untouched benchmarks

@zzstoatzz zzstoatzz force-pushed the pendulum-consolidation-mega branch from 8d3626c to c0389d2 Compare February 11, 2025 21:33
@zzstoatzz zzstoatzz merged commit 30d8cb0 into main Feb 11, 2025
47 checks passed
@zzstoatzz zzstoatzz deleted the pendulum-consolidation-mega branch February 11, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants