Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI-v2] feat: finish flows page #17108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

devangrose
Copy link
Contributor

finished up flows page and aligned its styling to be closer to existing OSS implementation

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

image

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 11, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO if flowRun[0] is expected, just throw an assert saying its expected. This should help resolve weird TS issues, and if the assert does get thrown, then it at least signals that our assumptions are wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants