Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(account-role): update expected role counts #246

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

mitchnielsen
Copy link
Contributor

@mitchnielsen mitchnielsen commented Aug 20, 2024

Updates the expected role counts in the account role datasource. These must have changed in Prefect itself.

Noticed while testing in other PRs - example run. Was able to replicate the problem on main.

Updates the expected role counts in the account role datasource. These
must have changed in Prefect itself.
@mitchnielsen mitchnielsen added bugfix Fixing a bug maintenance Maintenance work - won't show in release notes labels Aug 20, 2024
@mitchnielsen mitchnielsen self-assigned this Aug 20, 2024
@@ -25,7 +25,7 @@ resource "prefect_flow" "flow" {
}

resource "prefect_deployment" "deployment" {
name = "%s"
name = "my-deployment"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, the TF docs job ran on the last commit in the related PR and said it had nothing to commit: https://github.com/PrefectHQ/terraform-provider-prefect/actions/runs/10397466852/job/28793213803

Guess it's catching up now.

@mitchnielsen mitchnielsen marked this pull request as ready for review August 20, 2024 23:14
@mitchnielsen mitchnielsen requested a review from a team as a code owner August 20, 2024 23:14
@mitchnielsen mitchnielsen merged commit f644b6d into main Aug 21, 2024
@mitchnielsen mitchnielsen deleted the fix-account-role-test branch August 21, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing a bug maintenance Maintenance work - won't show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants