Deployments: support schedule
#304
Merged
+915
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of schedules support by implementing it directly in the deployment resource.
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
changed the title
schedule
One schedule, not a list of them.
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
- Copy schedule to model - Validate schedule length of 1 - Add missing fields in payloads
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
I was seeing an issue where my create payload would set active=false, but the API would return a schedule where active=true. I noticed that active=true is the default in the Prefect API, so I suspect something about that conflict with Go's default value for active (false) has something to do with it. Changing this value to a pointer, and passing ValueBoolPointer in the payloads and state configuration seems to fix the problem. This definitely needs further thought.
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
This will use the state when the ID is not in the plan, which it won't ever be because it's not configured by the user. This way we don't have to get the current state just to pull the schedule ID.
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
commented
Nov 21, 2024
Comment on lines
+375
to
+382
| //nolint:ireturn // required to return a diagnostic | ||
| func validateSchedules(schedules []*api.DeploymentSchedule) diag.Diagnostic { | ||
| if len(schedules) != 1 { | ||
| return diag.NewErrorDiagnostic("Unsupported number of schedules", fmt.Sprintf("Expected 1 schedule, got %d. Only one schedule is supported.", len(schedules))) | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
We'll have to limit to 1 schedule at a time for now. Opened https://linear.app/prefect/issue/PLA-772/deployments-support-multiple-schedules to investigate support for multiple schedules.
There was a problem hiding this comment.
Added a note to the docs as well
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
force-pushed
the
deployments-support-schedule
branch
from
622a832
to
a5eb780
Compare
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
parkedwards
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://linear.app/prefect/issue/PLA-440/deployments-support-schedules
References
Notes