Deduplicate client HTTP requests #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP requests across all of our PrefectClient-compatible clients are very similar, leading to a lot of duplicate code. This leaves room for error when adding new clients, and makes things a bit tougher to maintain. This change adds helper functions to replace this redundant code, coming with all the usual benefits of DRY-ing things up. This is also relevant as we aim for parity with the Prefect API, and the less code we have to write, the better! Related to https://linear.app/prefect/issue/PLA-690/cycle-6-catch-all
mitchnielsen
added
the
maintenance
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
parkedwards
reviewed
Nov 23, 2024
mitchnielsen
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
…t into dedupe-client-code
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper functions for common HTTP requests
The HTTP requests across all of our PrefectClient-compatible clients are
very similar, leading to a lot of duplicate code. This leaves room for
error when adding new clients, and makes things a bit tougher to
maintain.
This change adds helper functions to replace this redundant code, coming
with all the usual benefits of DRY-ing things up.
This is also relevant as we aim for parity with the Prefect API, and the
less code we have to write, the better!
Related to https://linear.app/prefect/issue/PLA-690/cycle-6-catch-all