chore(tests): run acceptance tests on main w/o approval #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkedwards
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
parkedwards
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normally, our Acceptance Tests are run with approval because the GH environment contains secrets that theoretically could be exfiltrated
However, this made it so that merges to main would have pending Acceptance Tests. While it's unlikely that a commit is merged without running these tests first, it's probably good to cover our bases and have them run automatically on main merge
To facilitate that, I've created a separate GH environment called
Acceptance Tests (main), which can only be used on a protected branch (eg.main)This environment has the same secrets, but will run without any approval needed