Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(automations): datasource support #310

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

parkedwards
Copy link
Contributor

Copy link
Contributor

@mitchnielsen mitchnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good from my side, great stuff. weird that the CI checks didn't run?


//nolint:paralleltest // we use the resource.ParallelTest helper instead
func TestAccDatasource_automation(t *testing.T) {
eventTriggerAutomationResourceName := testutils.NewRandomPrefixedString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no changes required) something I forgot to mention in the Resource PR: because we're using ephemeral workspaces, I don't believe we need the resource names to be random

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm - i thought they had to be unique (even across test cases) so that they wouldn't overwrite the resource in the TF state. i know this is the datasource test, but if we were in the resource test and used the same names, wouldn't they perform an Update()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, I may be writing tests slightly with different expectations - I assume each test case is updating an existing resource so I can test Update functionality. Sounds like it may just be a different use case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah interesting

@parkedwards parkedwards merged commit 7bc03b2 into main Nov 26, 2024
@parkedwards parkedwards deleted the feat/automation-datasource branch November 26, 2024 18:02
@parkedwards parkedwards added the enhancement New feature or request label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants