Skip to content

Commit

Permalink
Replace IS_IN_DOCKER env var by PHP_URL
Browse files Browse the repository at this point in the history
  • Loading branch information
Quetzacoalt91 committed Nov 21, 2024
1 parent 7138e89 commit ac0fe21
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion storybook/.docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ RUN composer install --no-dev --no-interaction --optimize-autoloader


FROM node:20
ENV IS_IN_DOCKER 1
ENV PHP_URL http://storybook-php:8000

RUN apt update \
&& apt install -y php8.2 php-dom \
Expand Down
4 changes: 1 addition & 3 deletions storybook/.storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ const config: StorybookConfig = {
options: {
// 👇 Here configure the framework
symfony: {
server: process.env.IS_IN_DOCKER
? "http://storybook-php:8000"
: "http://localhost:8003",
server: process.env.PHP_URL || "http://localhost:8003",
proxyPaths: ["/assets"],
additionalWatchPaths: ["assets"],
},
Expand Down
2 changes: 1 addition & 1 deletion storybook/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ services:
dockerfile: storybook/.docker/Dockerfile
command: npm run storybook
environment:
IS_IN_DOCKER: true
PHP_URL: http://storybook-php:8000
volumes:
- ./../:/autoupgrade
working_dir: /autoupgrade/storybook
Expand Down

0 comments on commit ac0fe21

Please sign in to comment.