Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI tests - Add PS version 1.7.0.6 to 1.7.8.11 on php 7.1 #729

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

UI tests - Add PS version 1.7.0.6 to 1.7.8.11 on php 7.1 #729

wants to merge 7 commits into from

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Jun 21, 2024 •
edited
Loading

Questions Answers
Description? Add PS version 1.7.0.6 to 1.7.8.11 on php 7.1
Type? new feature
Sponsor company
How to test? CI is 🍏

@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review June 21, 2024 12:12
@nesrineabdmouleh nesrineabdmouleh marked this pull request as draft June 21, 2024 12:13
@nesrineabdmouleh nesrineabdmouleh changed the title UI tests - Add autoupgrade of all versions of PS 1.7.. to 1.7.8.11 php 7.1 UI tests - Add PS versions from 1.7.0.0 ~ 1.7.0.6 to 1.7.8.11 (minor) on php 7.1 Jul 10, 2024
@nesrineabdmouleh nesrineabdmouleh force-pushed the addPSVersionsToMatrice branch 2 times, most recently from bba5009 to 853fd3a Compare July 16, 2024 08:54
@Quetzacoalt91
Copy link
Member

The error is happening because an URL we depend on to get data is now invalid.

It has been fixed on 1.7.1.0 with PrestaShop/PrestaShop#7597. We cannot fix this issue without modifying the core files on the fly to change the URL before starting the installation.
If these versions can't be installed anymore (1.7.0.*), they may be removed from the test matrix.

What do you think @nesrineabdmouleh & @gericfo?

@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review August 5, 2024 12:42
@nesrineabdmouleh nesrineabdmouleh added the Blocked Status: The issue is blocked by another task label Aug 5, 2024
Progi1984
Progi1984 previously approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nesrineabdmouleh The CI is red

@nesrineabdmouleh nesrineabdmouleh marked this pull request as draft August 5, 2024 13:22
@nesrineabdmouleh
Copy link
Contributor Author

@nesrineabdmouleh The CI is red

Yes it wip but to run the jobs the PR should not be in draft

@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review September 11, 2024 12:45
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nesrineabdmouleh nesrineabdmouleh marked this pull request as draft October 1, 2024 08:14
@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review November 14, 2024 22:47
@nesrineabdmouleh nesrineabdmouleh changed the title UI tests - Add PS versions from 1.7.0.0 ~ 1.7.0.6 to 1.7.8.11 (minor) on php 7.1 UI tests - Add PS version 1.7.0.6 to 1.7.8.11 on php 7.1 Nov 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 left review comments

@Progi1984 Progi1984 Progi1984 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Blocked Status: The issue is blocked by another task wip
Projects
PR Dashboard
Status: Reopened
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nesrineabdmouleh @Quetzacoalt91 @Progi1984