Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getUserIdentifier method to match SF6 new interface #22

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Add getUserIdentifier method to match SF6 new interface #22

merged 2 commits into from
Aug 8, 2023

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Aug 8, 2023 •
edited
Loading

Questions Answers
Description? Add getUserIdentifier method to match SF6 new interface, this is required by this PR from the core PrestaShop/PrestaShop#32992
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? ~
How to test? ~

@mflasquin
Copy link
Contributor

mflasquin commented Aug 8, 2023 •
edited
Loading

Just tested in live, I works like a charm :D

@jolelievre jolelievre added this to the 1.0.4 milestone Aug 8, 2023
@jolelievre
Copy link
Contributor Author

Thanks @mflasquin and me

@jolelievre jolelievre merged commit 8f6f77f into PrestaShop:master Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflasquin mflasquin mflasquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jolelievre @mflasquin