Test Organization build-release.yml in productcomments repo

[leemyongpakvn]

Questions	Answers
Description?	update_release_draft of Organizaion Build & Release failed when Release new version. We need test it separately in this repository.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#33728
How to test?	Github Build update_release_draft succeed in Release 6.0.1

[matks]

So you replace the Github action global by a custom one. What are the changes that you introduce and will fix the problem?

[M0rgan01]

I think removing the cd will fix the problem.

[leemyongpakvn]

I think so. The logic is simple: if you are inside productcomments folder, you can not zip it; you need to be in 1 level up, in modules folder. But this command is OK before. So we really need test it in action :)

[leemyongpakvn]

If we make changes directly in https://github.com/PrestaShop/.github/blob/master/.github/workflows/build-release.yml, it will affects all modules. So I choose copying Organization build-release.yml content to this repo for safety (not a custom one, it is an exact copy for testing).
I doubt this commit PrestaShop/.github@aba1484
or outdated actions/[email protected] raises the update_release_draft issue.
And we need an environment to test it in action, right?

[Hlavtox]

@leemyongpakvn The build script is broken in all module repositories and themes, so why don't we apply it globally?

[leemyongpakvn]

@Hlavtox For safety, once we fix the issue locally in this repo, we will apply it globally.

[Hlavtox]

@leemyongpakvn OK brother, sounds good. :-)

[leemyongpakvn]

@M0rgan01 I tried to remove ${{ github.event.repository.name }} at line 24 in deploy step. If it does not work, we can try to remove cd ${{ github.event.repository.name }} at line 40 in update_release_draft step

[M0rgan01]

Let's see what it gives

[matks]

If we make changes directly in https://github.com/PrestaShop/.github/blob/master/.github/workflows/build-release.yml, it will affects all modules. So I choose copying Organization build-release.yml content to this repo for safety (not a custom one, it is an exact copy for testing).

Good approach 👍

[M0rgan01]

@leemyongpakvn asset_path: ./${{ github.event.repository.name }}/${{ github.event.repository.name }}.zip must also be replaced by asset_path: ./${{ github.event.repository.name }}.zip.

And I think afterwards it will be good

[leemyongpakvn]

I don't think so. I think old cd ${{ github.event.repository.name }} is correct since https://github.com/PrestaShop/contactform/releases/tag/v4.4.1 and https://github.com/PrestaShop/ps_languageselector/releases/tag/v2.1.3 were built correctly in March, while https://github.com/PrestaShop/ps_linklist/releases/tag/v6.0.3 on 23 June need manual change - 10 days after actions/[email protected] outdated
as you can see in the recent actions Annotations: https://github.com/PrestaShop/productcomments/actions/runs/6000817427

[leemyongpakvn]

Moved to the related issue :)

[leemyongpakvn]

@M0rgan01 After carefully checking Actions of recent Releases of Native modules between March and June this year, I think you are right now ;) Unfortunately, the non-native module qualityassurance does not have BuildRelease workflow so we must continue testing on this repo. PR #184 is waiting.