Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache management with lifetime #43

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Cache management with lifetime #43

wants to merge 3 commits into from

Conversation

lmeyer1
Copy link
Contributor

@lmeyer1 lmeyer1 commented Jul 22, 2022

Questions Answers
Description? Cache only if there is only one product (avoid exponential number of files). Do not empty cache on order change (avoid interference with payment). Add a button in BO to clear the cache. Use a configurable cache life time.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#24338.
How to test? Configure the setting in the BO. Look at the generated cache files in the filesystem at /var/cache/dev/smarty/cache/ps_crossselling

As discussed here #42, cache lifetime seems to be a better option to clear the cache than product object hooks. IMO this PR should replace the previous. I'm waiting for feedback.

@lmeyer1 lmeyer1 mentioned this pull request Jul 31, 2022
Closed
@Hlavtox Hlavtox added this to the 2.0.2 milestone Jan 31, 2023
@Hlavtox Hlavtox modified the milestones: 2.0.2, 2.0.3 Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting for PM
Projects
PR Dashboard
Status: Waiting for PM/UX/Dev
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

ps_crossselling : Smarty cache clearing can break payment flow
3 participants
@lmeyer1 @Hlavtox @MatShir