Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache sha1 file #76

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cache sha1 file #76

wants to merge 3 commits into from

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Dec 16, 2024

based on #62
This just adds an extra sha1 file to not calculate it each time(I expect the file downloaded to not change until fully removed)

getchoo
getchoo reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

Would be nice to have some types assigned to these, though

@Trial97
Copy link
Member Author

Trial97 commented Dec 17, 2024

Would be nice to have some types assigned to these, though

Types to functions arguments? or to what exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trial97 @getchoo