Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update installing-java.md for prism 9.0+ #673

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

maskersss
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for prismlauncher ready!

Name Link
🔨 Latest commit 3502aad
🔍 Latest deploy log https://app.netlify.com/sites/prismlauncher/deploys/6777b99024b0480008737517
😎 Deploy Preview https://deploy-preview-673--prismlauncher.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: TheKodeToad <[email protected]>
Signed-off-by: maskers <[email protected]>
@TheKodeToad
Copy link
Member

I think Selecting Java, Installing Java on Windows, Installing Java on macOS, Installing Java on Linux and Special cases should be ## instead of # as they should really be subheadings under Manually installing Java

@maskersss
Copy link
Contributor Author

oh really, you can't have two heading 1's

@maskersss
Copy link
Contributor Author

is this better?

@TheKodeToad
Copy link
Member

oh really, you can't have two heading 1's

Actually, it's probably best to have # Installing Java right at the top too

src/wiki/getting-started/installing-java.md Outdated Show resolved Hide resolved
src/wiki/getting-started/installing-java.md Outdated Show resolved Hide resolved
src/wiki/getting-started/installing-java.md Outdated Show resolved Hide resolved
Co-authored-by: seth <[email protected]>
Signed-off-by: maskers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants