Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added event types #456

Closed
wants to merge 2 commits into from
Closed

Added event types #456

wants to merge 2 commits into from

Conversation

TM-Grant3
Copy link

No description provided.

extremeheat
extremeheat requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@extremeheat extremeheat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you generating this? It would need to be kept up to date with mcdata. It's better to have no or any type than broken or incomplete types as that will break typescript builds.

index.d.ts
@@ -116,8 +117,11 @@ declare module 'bedrock-protocol' {
* Send a disconnect packet and close the connection
*/
disconnect(): void

on(event: Packets, cb: (client: Player) => void): any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type on this is wrong

@TM-Grant3 TM-Grant3 closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extremeheat extremeheat extremeheat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TM-Grant3 @extremeheat