Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 1.21.1 #31

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Support 1.21.1 #31

merged 2 commits into from
Nov 27, 2024

Conversation

Icyadam14
Copy link
Contributor

This will close issue #29. I just ran image_names.js. I did not do any testing with the extracted data.

@Icyadam14 Icyadam14 marked this pull request as ready for review November 27, 2024 05:14
@rom1504
Copy link
Member

rom1504 commented Nov 27, 2024

1.21.1 folder needs to go in data/

@Icyadam14
Copy link
Contributor Author

Whoops! I moved the 1.21.1 folder and updated the README.

@rom1504 rom1504 merged commit e901c88 into PrismarineJS:master Nov 27, 2024
@rom1504
Copy link
Member

rom1504 commented Nov 27, 2024

Thanks

@rom1504
Copy link
Member

rom1504 commented Nov 27, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Nov 27, 2024
@rom1504
Copy link
Member

rom1504 commented Nov 27, 2024

Can you update https://github.com/PrismarineJS/node-minecraft-assets/blob/master/index.js#L131 as well in a PR in that repo ?

@Icyadam14
Copy link
Contributor Author

@rom1504
Copy link
Member

rom1504 commented Nov 27, 2024

@Icyadam14
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants