1.18+ Book editing feature #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extremeheat
reviewed
May 7, 2024
data/pc/common/features.json
Outdated
Comment on lines
240
to
248
| "name": "hasEditBookPacket", | ||
| "description": "book editing is handled through a packet", | ||
| "description": "book editing is handled through a packet with the updated book item", | ||
| "versions": [ | ||
| "1.13", | ||
| "1.17.1" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "hasNonNbtEditBookPacket", |
There was a problem hiding this comment.
The feature naming is confusing here. Can you elaborate what exactly the difference in packet is before vs after?
There was a problem hiding this comment.
The old edit book packet serializes the item and uses the nbt data from that
New packet sends the pages and title as packet fields
There was a problem hiding this comment.
How about adding a new editBookPacketUsesNbt feature then (to match old versions)? This seems clearer than the current naming between hasEditBookPacket and hasNonNbtEditBookPacket, as there is actaully an edit book packet on both version ranges.
extremeheat
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.18 a new book editing packet was added
PrismarineJS/mineflayer#3204