Handle unknown scoreboard objectives #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mineflayer will throw if given a scoreboard objective packet with the update action if the objective does not exist.
This "fixes" that by simply emitting an error event instead, allowing the user to do their own error handling.
Vanilla client will also throw when this happens, but will not disconnect the client, so I think simply emitting the error event is the right thing to do, so the user can handle it themselves and decide whether or not to disconnect. Cross-checked only with Vanilla 1.8 client, might have different behaviour in higher versions, but regardless I don't think we can handle it any different than this.