Fix for a possible error in lib/plugins/entities.js file #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding if statement around entity.type = entityData.type || 'object' to fix "TypeError: Cannot read properties of undefined (reading 'type')"
rom1504
reviewed
Dec 30, 2023
| @@ -197,7 +197,9 @@ function inject (bot) { | |||
| const entity = fetchEntity(packet.entityId) | |||
| const entityData = bot.registry.entities[packet.type] | |||
|
|
|||
| entity.type = entityData.type || 'object' | |||
There was a problem hiding this comment.
can you rather move this line to setEntityData ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this error happens with vanilla Minecraft, but when I tried to use mineflayer with node-minecraft-protocol-forge, I receive the following error shortly after my bot joins a server with TeamAbnormals mods:
The pull request fixes this error by adding an if statement around
entity.type = entityData.type || 'object'line.