Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes android collection FPs #870

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Fixes android collection FPs #870

merged 6 commits into from
Dec 12, 2023

Conversation

tuxology
Copy link
Contributor

  • also adds linked XML filename in code excerpt
  • filter for FP looks for either R.id or binding in sibling. This might avoid additional findViewById filter

@tuxology
Fixes android collection FPs
b493d7f 
 * also adds linked XML filename in code excerpt
khemrajrathore
khemrajrathore previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@khemrajrathore khemrajrathore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khemrajrathore
Copy link
Member

@tuxology There seems some conflict with base branch

@tuxology tuxology force-pushed the collection-misc-fixes branch from 7d0d9be to ff95ea0 Compare December 11, 2023 17:46
@khemrajrathore khemrajrathore merged commit a0ddd1a into dev Dec 12, 2023
9 of 10 checks passed
@khemrajrathore khemrajrathore deleted the collection-misc-fixes branch March 4, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khemrajrathore khemrajrathore khemrajrathore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxology @khemrajrathore