PHP Integration

[tuxology]

• integrate PHP Frontend from upstream Joern into Privado
• vendor PHP Parser from upstream fork into Privado and use it
• Use 4GB heap size for the tests to run in CI.

[khemrajrathore]

Overall changes look good to me, If we can also have some test cases around PHP parsing and tagging that would be great

[karan-batavia]

Can we please have some tests on the basic tagging process? Let's ensure the integration stays solid from the start itself.
@pawan-privado

[pawan-privado]

Can we please have some tests on the basic tagging process? Let's ensure the integration stays solid from the start itself. @pawan-privado

Sure!

[karan-batavia]

Also, when are we planning to release these changes? Let's make sure we don't conflict with the C# release on Monday.
@pawan-privado @tuxology

[pawan-privado]

@tuxology Test failed because PHP parser could not be executed.

Error:  Invalid path for PhpParserBin: /home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/io/joern/php2cpg/bin/php-parser/php-parser.php

The path doesn't look right to me. Is this the intended path for vendoring the parser?

[tuxology]

@tuxology Test failed because PHP parser could not be executed.

Error:  Invalid path for PhpParserBin: /home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/io/joern/php2cpg/bin/php-parser/php-parser.php

The path doesn't look right to me. Is this the intended path for vendoring the parser?

@pawan-privado It looks like this is only happening in Github - the path for php-parser is possibly null and hence the default path is being picked (which is not vendored path). This was working before C# push (a883357) so if you can investigate and fix, it would help 👍

[pawan-privado]

@tuxology Test failed because PHP parser could not be executed.

Error:  Invalid path for PhpParserBin: /home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/io/joern/php2cpg/bin/php-parser/php-parser.php

The path doesn't look right to me. Is this the intended path for vendoring the parser?

@pawan-privado It looks like this is only happening in Github - the path for php-parser is possibly null and hence the default path is being picked (which is not vendored path). This was working before C# push (a883357) so if you can investigate and fix, it would help 👍

The reason why we did not notice this happen in our dev machines is because we had the required env variable set and the path was being picked up from the variable. I've made changes accordingly.

[kbatavia12]

LGTM

[khemrajrathore]

@pawan-privado Take a merge of dev, they we are good to go

[khemrajrathore]

LGTM