imp: Deprecate the creation of sub-organizations

More information: #516
Probesys · Dec 7, 2023 · ee2cc44 · ee2cc44
1 parent d263301
commit ee2cc44
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 16 deletions.
diff --git a/src/Command/SeedsCommand.php b/src/Command/SeedsCommand.php
@@ -121,19 +121,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'name' => 'Probesys',
             ]);
 
-            // Make sure to have an ID for the Probesys organization.
-            $this->entityManager->flush();
-
-            $orgaWebDivision = $this->orgaRepository->findOneOrCreateBy([
-                'name' => 'Web team',
-                'parentsPath' => "/{$orgaProbesys->getId()}/",
-            ]);
-
-            $orgaNetworkDivision = $this->orgaRepository->findOneOrCreateBy([
-                'name' => 'Network team',
-                'parentsPath' => "/{$orgaProbesys->getId()}/",
-            ]);
-
             $orgaFriendlyCoorp = $this->orgaRepository->findOneOrCreateBy([
                 'name' => 'Friendly Coorp',
             ]);
@@ -183,7 +170,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 $this->authorizationRepository->grant($userAlix, $roleTech, null);
             }
 
-            if (!$this->authorizationRepository->getOrgaAuthorizationFor($userBenedict, $orgaWebDivision)) {
+            if (!$this->authorizationRepository->getOrgaAuthorizationFor($userBenedict, null)) {
                 $this->authorizationRepository->grant($userBenedict, $roleSalesman, null);
             }
 
@@ -299,7 +286,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 'urgency' => 'medium',
                 'impact' => 'medium',
                 'priority' => 'medium',
-                'organization' => $orgaWebDivision,
+                'organization' => $orgaProbesys,
                 'requester' => $userBenedict,
                 'assignee' => null,
             ]);

diff --git a/templates/organizations/index.html.twig b/templates/organizations/index.html.twig
@@ -59,12 +59,16 @@
                             ) }}
                         </ul>
 
+                        {# Disabled while we are considering a better solution.
+                         # See https://github.com/Probesys/bileto/issues/516
+
                         <div class="text--small">
                             <a href="{{ path('new organization', { parent: organization.uid }) }}">
                                 {{ icon('plus') }}
                                 {{ 'organizations.index.new_sub_organization' | trans }}
                             </a>
                         </div>
+                        #}
                     </li>
                 {% endfor %}
             </div>

diff --git a/tests/Command/SeedsCommandTest.php b/tests/Command/SeedsCommandTest.php
@@ -28,7 +28,7 @@ public function testExecute(): void
 
         $this->assertSame(Command::SUCCESS, $tester->getStatusCode(), $tester->getDisplay());
         $this->assertSame(4, RoleFactory::count());
-        $this->assertSame(4, OrganizationFactory::count());
+        $this->assertSame(2, OrganizationFactory::count());
         $this->assertSame(3, UserFactory::count());
         $this->assertSame(1, MailboxFactory::count());
     }