Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: Reopen resolved ticket if answerer is not an agent #932

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

marien-probesys
Copy link
Member

@marien-probesys marien-probesys commented Jan 16, 2025

Related issue(s)

#903

How to test manually

  1. Grant authorization to a simple user to access all the tickets of an organization
  2. Create a ticket in this organization, without setting the user as requester or even observer
  3. As an agent, resolve the ticket
  4. As a user, answer to the ticket
  5. Verify the ticket is now "in progress" and that the solution has been removed
  6. Do the same by email

Reviewer checklist

  • Code is manually tested
  • Permissions / authorizations are verified
  • New data can be imported
  • Interface works on both mobiles and big screens
  • Interface works in both light and dark modes
  • Interface works on both Firefox and Chrome
  • Accessibility has been tested
  • Translations are synchronized
  • Tests are up to date
  • Copyright notices are up to date
  • Documentation is up to date
  • Pull request has been reviewed and approved

There are cases where an observer or a user allowed to access all the
tickets answers to a "resolved" ticket. In this case, the ticket stayed
in this status. However, in many cases, the ticket needs the attention
of the agents.

Now, the ticket is reopened and the solution removed, so the agents
cannot miss a "not so resolved" ticket.
@marien-probesys marien-probesys merged commit fd8152e into main Jan 16, 2025
6 checks passed
@marien-probesys marien-probesys deleted the 903/imp/reopen-resolved-on-user-answer branch January 16, 2025 09:21
@marien-probesys marien-probesys added this to the Version 0.14 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant