Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove External Integrations Setting Due to CDATA Package Deprecation #7842

Open
wants to merge 1 commit into
base: release-2024-fall
Choose a base branch
from

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Dec 18, 2024

This PR removes the "External Integrations" option in the settings table, as it is no longer needed following the deprecation of the CDATA Package.

Changes

  • Added a migration to remove the settings related to "External Integrations" (CDATA).

How to Test

  1. Ensure the docker-executor-cdata and package-cdata are installed.
  2. Confirm the "External Integrations" setting exists in the database and UI.
  3. Run php artisan migrate.
  4. Verify the "External Integrations" setting is removed from the database and UI.
  5. Run php artisan migrate:rollback --step=1
  6. Verify the "External Integrations" setting is restored in the database and UI.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanjacornelius
This deletes the records and disables the cdata section, but if the package is reinstalled via package-cdata:install, the records will return and the migration won’t be able to delete them again. We need to ensure that package-cdata and docker-executor-cdata are also removed from the composer.json before running the migration.. or Should this perhaps also be handled in this PR?

@eiresendez eiresendez self-requested a review December 18, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants