Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC FOUR-18012] Screen Template V2 Implementation #1729

Merged
merged 51 commits into from
Oct 9, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Oct 7, 2024

This PR consolidates all updates related to Screen Template V2 within the Screen Builder, allowing users to apply a screen template to an existing screen. The updates include UI enhancements and Cypress test coverage to ensure functionality.

Changes:

  1. UI Updates:
    • Implemented template selection functionality in the left panel of the Screen Builder.
  2. Cypress Test Implementation:
    • Added Cypress tests to verify that templates are correctly displayed in the left panel.

Related Tickets & Packages

FOUR-18012

Core PR

.

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

mcraeteisha and others added 30 commits August 27, 2024 18:02
Add Screen Templates Section in Screen Builder
…ot installed

Also for use in screen-builder standalone
For cypress testing and screen-builder standalone
Instead of fetching from core
Or if a user is in screen-builder standalone
FOUR-18303 | Write Tests for Screen Templates Section
FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates
Copy link

cypress bot commented Oct 7, 2024

screen-builder    Run #1476

Run Properties:  status check passed Passed #1476  •  git commit 1623f9a4ef: [EPIC FOUR-18012] Screen Template V2 Implementation
Project screen-builder
Run status status check passed Passed #1476
Run duration 07m 46s
Commit git commit 1623f9a4ef: [EPIC FOUR-18012] Screen Template V2 Implementation
Committer Sanja
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 301

@sanjacornelius sanjacornelius changed the title [WIP] Screen Templates V2 [EPIC FOUR-18012] Screen Template V2 Implementation Oct 7, 2024
@sanjacornelius sanjacornelius changed the base branch from next to release-2024-fall October 8, 2024 16:35
@ryancooley ryancooley merged commit 8325b62 into release-2024-fall Oct 9, 2024
14 checks passed
@ryancooley ryancooley deleted the epic/FOUR-18012 branch October 9, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants