-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FHIR format datalist for 3D classification example #32
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nic Ma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Nic-Ma would be nice to have a review from the data working group, I place a "request change" for now
Sure, sounds good a plan. |
A few comments;
|
Hi @IntegratorBrad , Sorry for my late response, we are busy with MONAI 0.4 tasks for stability.
And for comment 5, I didn't spend much time to study FHIR structures, just referred to your samples in the working group proposal. Could you please help understand what I should modify to address comment 5? Thanks. |
I posted a thread in FHIR Zulip chat to check with the community. Essentially though; A challenge with a single object - e.g.,
.. is that, what if you want to have both the original NIFTI and the annotation NIFTI? Maybe, if it is two NIFTIs, you would reference it as follows:
This would support if you have multiple annotations on the same dataset, too. The problem though still is that the "annotation" is in the note, which makes it free text, which makes it hard to port into other languages or applications. It feels as though it should be a custom FHIR resource, like this:
... but this should be explored further with the FHIR community. |
This PR added datalist file in FHIR format for the PyTorch 3D classification example, which is the first step for the proposal from data working group.