Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ZefraControl bot #25

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

kharism
Copy link

@kharism kharism commented Jul 30, 2020

Add ZefraControl deck
Still need to use some hack to deals with pendulum summoning due to usual function is not executable.

kharism added 10 commits July 24, 2020 22:26
Add normal summon target
Add VFD Stun to dark
Add Fairytail luna bounce
Add ZefraWar Routine
bugfix zefraath search (still need testing)
bugfix scale completition routine
bugfix fairytail luna, still not working as intended for some reason
hack fairy tail luna
change how some card should be used
add case to handle scale completition
add hack to differentiate between pendulum summon and using gamma
Copy link

@kevinlul kevinlul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for submitting this executor and sorry it took so long to come around and review! I have some concerns about the effectiveness of the deck submitted and code quality. Please have a look at the individual comments so far.

88581108
23935886
!side

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason why the deck is in this order instead of being sorted? The deck also seems to brick a lot so you might want to reconsider your ratios and strategies. The Extra Deck also contains only 13 cards.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any sort of metric I can use to tune the deck? something like at least 1 negate over 75% of the time or something. Do I have to make it as competitive as possible with very low margin of error?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a particular metric but I found that the deck was bricking very often and not getting any plays off because of the ratios. Zefraath pass is not a particularly convincing first-turn play. It doesn't have to be as competitive as possible in the meta sense, but it should certainly do something instead of consistently losing to Normal monster mash.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood

@@ -55,6 +55,7 @@
<ItemGroup>
<Compile Include="Config.cs" />
<Compile Include="Game\AI\Deck.cs" />
<Compile Include="Game\AI\Decks\ZefraControlExecutor.cs" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this entry to be adjacent to the other executors.

public const int OracleZefra = 32354768;
public const int ZefraWar = 96073342;
public const int ZefraDivineStrike = 35561352;
public const int NinePilalrs = 57831349;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

public const int VampiricDragon = 93713837;
public const int TrueKingVFD = 88581108;
public const int DracoMasterOfTenyi = 23935886;
public const int PsyframelordLambda = 8802510;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This card isn't in the deck.

public const int StardustChargeWarrior = 64880894;
public const int EarthSlicer = 97584719;
public const int Enterblathnir = 95113856;
public const int PtolemyM7 = 38495396;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This card isn't in the deck.

for (int i = 1; i <= max; ++i)
{

ClientCard card = cards[cards.Count - i];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as OnSelectOption

return true;
}
//AI.SelectMaterials();
return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the comments here?

}
}
if (selected.Count == 0)
selected.Add(cards[cards.Count - 1]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

return false;
}
private bool CrocoDragonTrigger() {
if (ActivateDescription == Util.GetStringId(CardId.Crocodragon, 0)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return the if predicate

}
private bool OracleTrigger() {
if (ActivateDescription == Util.GetStringId(CardId.OracleZefra, 1)) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty branch, is this complete?

@edo9300 edo9300 force-pushed the master branch 2 times, most recently from 5e16a86 to 7691b54 Compare April 18, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants