Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle the WorkspaceExport form #3831

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Restyle the WorkspaceExport form #3831

merged 1 commit into from
Dec 12, 2023

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Nov 30, 2023

I think it's a little less weird to have the output contained in a visible accordion vs having the dialog itself scroll?

Before:
Screenshot 2023-11-30 at 09 28 34

After:
Screenshot 2023-11-30 at 09 27 59

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c938312) 92.46% compared to head (3ff4055) 92.44%.
Report is 6 commits behind head on mui5.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             mui5    #3831      +/-   ##
==========================================
- Coverage   92.46%   92.44%   -0.03%     
==========================================
  Files         202      202              
  Lines        3545     3548       +3     
==========================================
+ Hits         3278     3280       +2     
- Misses        267      268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcoyne jcoyne merged commit dd478de into mui5 Dec 12, 2023
6 checks passed
@jcoyne jcoyne deleted the mui5-export branch December 12, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants