Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ThumbnailNavigation to a function. #3994

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Nov 20, 2024

No description provided.

@cbeer cbeer marked this pull request as ready for review November 21, 2024 15:26
Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion makes sense to me and the feature works for me locally, including navigating by thumbnail and scrolling to the selected thumbnail, as well as the next/previous thumbnail buttons. The thumbnail selector strip works correctly in both vertical and horizontal forms.

@cbeer cbeer merged commit f1164fe into master Dec 2, 2024
6 of 7 checks passed
@cbeer cbeer deleted the thumbnail-function branch December 2, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants