Fix withSize regression #4000
Merged
Fix withSize regression #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
fix-withSize-ref-regression
branch
from
aa680d8
to
732e767
Compare
cbeer
force-pushed
the
fix-withSize-ref-regression
branch
from
732e767
to
f549380
Compare
jcoyne
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 19c2694, the added
<div>broke the ability to scroll companionWindows because the appropriate styles weren't in the right places in the DOM. This PR removes the additional div and instead ensures the withSize'd components appropriately forward refs to the underlying DOM element.