Fix undefined error in tip parsing #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Li <[email protected]>
|
Thanks! Can you use the nullish coalescing operator |
Signed-off-by: Frank Li <[email protected]>
|
@ryanio done, thank you |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 98.17% 98.16% -0.01%
==========================================
Files 33 33
Lines 14025 14025
Branches 672 673 +1
==========================================
- Hits 13769 13768 -1
- Misses 251 252 +1
Partials 5 5
☔ View full report in Codecov by Sentry. |
ryanio
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
fulfillOrdersflow when using a tip will hit this function and fungible (NATIVE) tokens will be mapped to have missingidentifierfield causing errors downstream.I removed the errornous comment and implemented the fix but due to limited capacity I didn't bother with tests :)
Solution