-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change BinderHub #85
Change BinderHub #85
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks let's hope 2i2c works. @brian-rose and @ktyle can you confirm if this is all we need to do to make the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This runs fine on the 2i2c Binder so I think it's good to go for now!
With this change, the "launch" buttons on individual chapter pages now point to the 2i2c binder. The binder badge on the README page still points to the Pythia binder. That badge is manually configured in the README file here |
Thanks for noting this! I was waiting to hear from Julia on what hub we should move to before making that update (clearly I should've done a quick search before putting in this PR - whoops). Interestingly, it seems like they are both working now. |
@brian-rose I was wondering about that, and went to fix it - but while I started the edits, the Binder resolved. Clicking the badge from the README, any of the pages, or from the cookbook gallery all load fairly quickly now. |
Might need to re-publish the Cookbooks gallery for that binder link to point to 2i2c as well. |
Both binders should work! And you can always launch the cookbook (any cookbook) in either binder manually by visiting either https://binder.projectpythia.org or https://hub.binder.pythia.2i2c.cloud/ and pasting in the repo name. The links in the cookbook are mostly just for convenience so users can click to deploy and not have to think about or care which binder they are visiting. So having different binder links in the README versus the individual chapter pages isn't really a problem, as long as both binders are functional. I believe the Pythia gallery pulls the binder link from the README file, not the config file. But I don't remember exactly. In an ideal world there would be only one binder link per cookbook to maintain... That might be something to explore as part of the MySTification of the cookbook template. |
I'm not sure exactly what happened, but for some reason the Pythia binder wasn't working properly earlier for this cookbook (#82). That issue seems to have resolved now. And I think you're right that the badge links are independent of the config. Thanks for the reminder about the manual option to launch / test these out. |
Yes, it seems like sometimes a bad image gets created on the binder. A simple workaround is often just to push a trivial new commit to the main branch of the cookbook repo, which then forces the binder to rebuild a new image for that repo. That seems to have resolved the problem in this case. |
Giving this a try to see if we can get things working.