Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap PR preview action #125

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Swap PR preview action #125

merged 2 commits into from
Oct 17, 2024

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Oct 7, 2024

Closes #120

Switch to use jamesives/github-pages-deploy-action@v4

@jukent jukent requested a review from erogluorhan October 10, 2024 14:55
@jukent
Copy link
Contributor Author

jukent commented Oct 10, 2024

Here is the deploy passing on my Cookbook-template repository fork (pointing to my forked cookbook-actions, using the new workflow).

Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this! Looks good to me

@erogluorhan erogluorhan merged commit 28fde27 into ProjectPythia:main Oct 17, 2024
jbusecke added a commit to jbusecke/cookbook-actions that referenced this pull request Oct 17, 2024
brian-rose added a commit that referenced this pull request Oct 25, 2024
Potential follow up fix for #125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR previews have undesired side effect for main page (deleted html pages are persisting)
2 participants