Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match template workflow changes #20

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Nov 21, 2022

@github-actions
Copy link

github-actions bot commented Nov 21, 2022

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 35af610
✅ Deployment Preview URL: https://ProjectPythiaCookbooks.github.io/packaging-cookbook/_preview/20

@jukent
Copy link
Contributor Author

jukent commented Nov 21, 2022

Binder link error:

( README: line 5) broken https://binder-staging.2i2c.cloud/v2/gh/ProjectPythiaCookbooks/packaging-cookbook/main?labpath=notebooks - 500 Server Error: Internal Server Error for url: https://binder-staging.2i2c.cloud/v2/gh/ProjectPythiaCookbooks/packaging-cookbook/main?labpath=notebooks

Nightly build is failing and Binder link doesn't work on main, so i think this test failure isn't because of introduced errors in this PR.

@brian-rose
Copy link
Member

Binder link error:

( README: line 5) broken https://binder-staging.2i2c.cloud/v2/gh/ProjectPythiaCookbooks/packaging-cookbook/main?labpath=notebooks - 500 Server Error: Internal Server Error for url: https://binder-staging.2i2c.cloud/v2/gh/ProjectPythiaCookbooks/packaging-cookbook/main?labpath=notebooks

Nightly build is failing and Binder link doesn't work on main, so i think this test failure isn't because of introduced errors in this PR.

Yeah, looks like this one never got fixed in ProjectPythia/cookbook-gallery#85.

We need to make sure the binder link the README is consistent with the one in the _config file. We don't have any automation for that (yet).

@jukent jukent merged commit 3e6c0f8 into ProjectPythia:main Nov 21, 2022
github-actions bot pushed a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants