Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bit of cleanup for today's soft release #81

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Conversation

dcamron
Copy link
Contributor

@dcamron dcamron commented Jun 16, 2021

Trimmed some file names, cleaned up some template adherence, cleared out unnecessary metadata, ran all the notebooks on the same kernel, cleared outputs and blank cells, reorganized a bit of the pandas material (@mgrover1 make sure you're okay with these changes!), and removed the OOP section in datetime (@brian-rose make sure this was a clean break, I didn't double check for any md references to this section).

@dcamron dcamron requested review from brian-rose and mgrover1 June 16, 2021 17:26
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@brian-rose
Copy link
Member

removed the OOP section in datetime (@brian-rose make sure this was a clean break, I didn't double check for any md references to this section).

I'll take a look at the text, but the link checker should catch any broken references.

@dcamron
Copy link
Contributor Author

dcamron commented Jun 16, 2021

Right, I just meant references within the text. I didn't see any immediately before or after, but just wanted to run it by you since you've had eyes on it.

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: ca51779 at: https://60ca36177c9d3c0df43be5ca--pythia-foundations.netlify.app

core/datetime/datetime.ipynb Show resolved Hide resolved
core/pandas/pandas.ipynb Show resolved Hide resolved
Clarify organization, trim file names, verify template-based
consistency. Clear out extra metadata and run all notebooks on standard
kernel.
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted over in ReviewNB the one place I saw a stale reference to the OOP section, to be removed. Otherwise, looks great. I think the additions to the Pandas section add a lot of clarity.

@brian-rose
Copy link
Member

@dcamron you may want to merge in the latest from main, which now includes the Xarray material from #33. Might need one or two tweaks for consistency with the other notebooks.

@dcamron
Copy link
Contributor Author

dcamron commented Jun 16, 2021

Yep, have already rebased and am running through those as well. I will likely just delete nc-cf if that's alright with you so it doesn't throw off any builds or anything in the future and just open an issue about that content. We'll always have it in the history and I have python-training copies as well. Also I might rename a few more things but maybe another time when more content goes in.

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: 187610c at: https://60ca41ea0581c617dccf7368--pythia-foundations.netlify.app

Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid @dcamron - thanks for making these changes

@github-actions
Copy link

🚀 📚 Preview for git commit SHA: 1ac20d8 at: https://60ca44063d7559186afa188d--pythia-foundations.netlify.app

@dcamron dcamron merged commit 7a72dc5 into ProjectPythia:main Jun 16, 2021
@dcamron dcamron deleted the cleanup branch June 16, 2021 18:37
@brian-rose
Copy link
Member

ha ha, approved after merge!

Thanks for the cleanup effort

@brian-rose brian-rose added this to the InitialPortalRelease milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel spec in template.ipynb
3 participants