-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bit of cleanup for today's soft release #81
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I'll take a look at the text, but the link checker should catch any broken references. |
Right, I just meant references within the text. I didn't see any immediately before or after, but just wanted to run it by you since you've had eyes on it. |
🚀 📚 Preview for git commit SHA: ca51779 at: https://60ca36177c9d3c0df43be5ca--pythia-foundations.netlify.app |
Clarify organization, trim file names, verify template-based consistency. Clear out extra metadata and run all notebooks on standard kernel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted over in ReviewNB the one place I saw a stale reference to the OOP section, to be removed. Otherwise, looks great. I think the additions to the Pandas section add a lot of clarity.
Yep, have already rebased and am running through those as well. I will likely just delete |
🚀 📚 Preview for git commit SHA: 187610c at: https://60ca41ea0581c617dccf7368--pythia-foundations.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid @dcamron - thanks for making these changes
🚀 📚 Preview for git commit SHA: 1ac20d8 at: https://60ca44063d7559186afa188d--pythia-foundations.netlify.app |
ha ha, approved after merge! Thanks for the cleanup effort |
Trimmed some file names, cleaned up some template adherence, cleared out unnecessary metadata, ran all the notebooks on the same kernel, cleared outputs and blank cells, reorganized a bit of the pandas material (@mgrover1 make sure you're okay with these changes!), and removed the OOP section in
datetime
(@brian-rose make sure this was a clean break, I didn't double check for any md references to this section).