-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickstart guide, keyframing, small updates #14
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Any suggestions are appreciated! For downloading the datasets and session files, I included links to the files in Google Drive. Let me know if there is a better way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ifranda. Looks good. A few suggestions:
- In the quickstart and other new notebooks. Can downloading the dataset be done as a cell int he notebook itself to prevent them from having to download it separately? What do you think?
I think we'd be able to! Is the dataset too big to host on GitHub? That would probably be the easiest because then they'd have it when they clone the repository. It's about 170 MB. Otherwise I think we could find another way! |
RDA would be a good option. I've moved VAPOR sample data to RDA. We can move Katrina data to the same place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks Ian.
Two suggestions:
- The download is working great! It might be good to check if the file already exists so that people are not re-downloading the file every time they run the notebook.
- How do you feel about including one cell to allow people rotate and look around in the scene just before exporting the image? Something similar to
viz = VaporVisualizerWidget(ses)
Good ideas! Another thought -- if users are following along by copying and pasting into their own workspace instead of cloning the whole repository, they won't have access to the get_data.py script. Another idea I had was to have a cell for command lines, like this:
|
Agreed. |
Ok, I've made some updates and I think it runs better! |
I got the image renderer working with a fresh conda build! But it looks like Natural Earth is the only builtin map at the moment, and I think that one only renders land, unless I'm wrong about that? Do you know if there's a way to get the oceans to render? Otherwise maybe we could try adding BigBlueMarble to the builtin maps |
You are right. The oceans are black in the dataset. Could this be another file that we could download? Alternatively, the black ocean down't look bad too... |
Adding two new notebooks