refactor database in log_output_db to DI

ProjektAdLer · Oct 27, 2024 · 3fc6c1b · 3fc6c1b
1 parent 40e80c2
commit 3fc6c1b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/classes/local/output/log_output_db.php b/classes/local/output/log_output_db.php
@@ -7,12 +7,10 @@
 use stdClass;
 
 class log_output_db implements log_output {
-    private moodle_database $db;
 
-    public function __construct(moodle_database $db = null) {
-        global $DB;
-        $this->db = $db ?? $DB;
-    }
+    public function __construct(
+        private readonly moodle_database $db
+    ) {}
 
     /**
      * @throws dml_exception

diff --git a/tests/local/output/log_output_db_test.php b/tests/local/output/log_output_db_test.php
@@ -1,5 +1,6 @@
 <?php
 
+use core\di;
 use local_logging\lib\adler_testcase;
 use local_logging\local\output\log_output_db;
 
@@ -13,7 +14,7 @@ public function test_output() {
         global $DB;
 
         // Create an instance of log_output_db.
-        $logOutput = new log_output_db();
+        $logOutput = di::get(log_output_db::class);
 
         // Define test data.
         $message = 'Test message';